-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Issue 130, updated gt, gte, lt, lte comparison methods #131
Fix for Issue 130, updated gt, gte, lt, lte comparison methods #131
Conversation
…ded tests for updated methods
Build test failing due to a bundler issue, please restart; tests pass locally. |
This failure on Travis happens occasionally ... well, more than occasionally ... and I'm not sure why:
The gemfile reveals that no version is specified for rake. Any idea why the sporadic failures? I'd like to get a Travis green light on this one. |
I'm not sure what's going on with Travis, the same error was reported in the previous pull request I submitted ( #124 ), but it passed. I have yet to find one community project that doesn't have consistent issues with Travis CI. The If I had to guess it would be something with the bundler path, but I'm not familiar enough with Travis to troubleshoot it further. |
Looking around the Travis issues, have you tried this in the
|
Noticed your recent commits, have you tried mirroring the language: objective-c
before_install:
- (ruby --version)
- sudo chown -R travis ~/Library/RubyMotion
- mkdir -p ~/Library/RubyMotion/build
- sudo motion update
script:
- bundle install
- bundle exec rake clean
- bundle exec rake spec
- bundle exec rake clean
- bundle exec rake spec osx=true Then again, |
I think it’s a problem with RubyMotion. In RubyMotion/lib/motion/util/version.rb, the version is compared against a non-empty regular expression. What version? I don’t know. RubyMotion version? App version? SDK version? Anyhow, that’s what’s failing now, so I filed a motion support issue. Let’s see what @eloy has to say...
|
Passes local tests. Should pass Travis with new travis.yml I just (finally) figured out. |
…rsed Fix for Issue 130, updated gt, gte, lt, lte comparison methods
Addresses issue #130