Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue 130, updated gt, gte, lt, lte comparison methods #131

Merged
merged 1 commit into from
Jan 30, 2015

Conversation

cognitiveflux
Copy link
Contributor

Addresses issue #130

@cognitiveflux
Copy link
Contributor Author

Build test failing due to a bundler issue, please restart; tests pass locally.

@sxross
Copy link
Owner

sxross commented Jan 28, 2015

This failure on Travis happens occasionally ... well, more than occasionally ... and I'm not sure why:

$ bundle exec rake spec
Could not find rake-10.1.0 in any of the sources
Run `bundle install` to install missing gems.

The gemfile reveals that no version is specified for rake. Any idea why the sporadic failures? I'd like to get a Travis green light on this one.

@cognitiveflux
Copy link
Contributor Author

I'm not sure what's going on with Travis, the same error was reported in the previous pull request I submitted ( #124 ), but it passed. I have yet to find one community project that doesn't have consistent issues with Travis CI.

The Gemfile.lock file has 10.1.0 specified, but in the test history for Travis it says that bundler installed rake correctly. Would you please try restarting the job?

If I had to guess it would be something with the bundler path, but I'm not familiar enough with Travis to troubleshoot it further.

@cognitiveflux
Copy link
Contributor Author

Looking around the Travis issues, have you tried this in the .travis.yml in the past?:

install: ruby -S bundle install

@cognitiveflux
Copy link
Contributor Author

Noticed your recent commits, have you tried mirroring the BubbleWrap travis config?

language: objective-c
before_install:
    - (ruby --version)
    - sudo chown -R travis ~/Library/RubyMotion
    - mkdir -p ~/Library/RubyMotion/build
    - sudo motion update
script:
    - bundle install
    - bundle exec rake clean
    - bundle exec rake spec
    - bundle exec rake clean
    - bundle exec rake spec osx=true

Then again, BW has been having build issues with Travis for eons.

@sxross
Copy link
Owner

sxross commented Jan 29, 2015

I think it’s a problem with RubyMotion. In RubyMotion/lib/motion/util/version.rb, the version is compared against a non-empty regular expression. What version? I don’t know. RubyMotion version? App version? SDK version? Anyhow, that’s what’s failing now, so I filed a motion support issue.

Let’s see what @eloy has to say...

On Jan 29, 2015, at 11:48 AM, cognitiveflux [email protected] wrote:

Noticed your recent commits, have you tried mirroring the BubbleWrap travis config?

language: objective-c
before_install:
- (ruby --version)
- sudo chown -R travis ~/Library/RubyMotion
- mkdir -p ~/Library/RubyMotion/build
- sudo motion update
script:
- bundle install
- bundle exec rake clean
- bundle exec rake spec
- bundle exec rake clean
- bundle exec rake spec osx=true
Then again, BW has been having build issues with Travis for eons.


Reply to this email directly or view it on GitHub #131 (comment).

@sxross
Copy link
Owner

sxross commented Jan 30, 2015

Passes local tests. Should pass Travis with new travis.yml I just (finally) figured out.

@sxross sxross closed this Jan 30, 2015
@sxross sxross reopened this Jan 30, 2015
sxross added a commit that referenced this pull request Jan 30, 2015
…rsed

Fix for Issue 130, updated gt, gte, lt, lte comparison methods
@sxross sxross merged commit 2c518d6 into sxross:master Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants